Findbugs all over

- volatile -> atomic
 - unused code and fields
 - closing streams
 - hashCode / equals
 - known non-null
 - Number.valueOf
 - new String
 Still avoiding SAM, BOB, SusiMail
This commit is contained in:
zzz
2013-11-16 13:22:05 +00:00
parent 96cf1d60c2
commit 1d4190734d
30 changed files with 107 additions and 64 deletions

View File

@@ -354,11 +354,17 @@ public class AddressbookBean extends BaseBean
{
String filename = properties.getProperty( getBook() + "_addressbook" );
FileOutputStream fos = new SecureFileOutputStream( ConfigBean.addressbookPrefix + filename );
addressbook.store( fos, null );
FileOutputStream fos = null;
try {
fos.close();
} catch (IOException ioe) {}
fos = new SecureFileOutputStream( ConfigBean.addressbookPrefix + filename );
addressbook.store( fos, null );
} finally {
if (fos != null) {
try {
fos.close();
} catch (IOException ioe) {}
}
}
}
public String getFilter() {