diff --git a/apps/BOB/src/net/i2p/BOB/DoCMDS.java b/apps/BOB/src/net/i2p/BOB/DoCMDS.java index ef102b67e..97ab9b65c 100644 --- a/apps/BOB/src/net/i2p/BOB/DoCMDS.java +++ b/apps/BOB/src/net/i2p/BOB/DoCMDS.java @@ -48,17 +48,17 @@ public class DoCMDS implements Runnable { // I need a better way to do versioning, but this will do for now. public static final String BMAJ = "00", BMIN = "00", BREV = "10", BEXT = ""; public static final String BOBversion = BMAJ + "." + BMIN + "." + BREV + BEXT; - private Socket server; - private Properties props; - private NamedDB database; + private final Socket server; + private final Properties props; + private final NamedDB database; private String line; private Destination d; private ByteArrayOutputStream prikey; private boolean dk, ns, ip, op; private NamedDB nickinfo; - private Logger _log; - private AtomicBoolean LIVE; - private AtomicBoolean lock; + private final Logger _log; + private final AtomicBoolean LIVE; + private final AtomicBoolean lock; /* database strings */ private static final String P_DEST = "DESTINATION"; private static final String P_INHOST = "INHOST"; diff --git a/apps/BOB/src/net/i2p/BOB/I2PtoTCP.java b/apps/BOB/src/net/i2p/BOB/I2PtoTCP.java index 11b401029..626693478 100644 --- a/apps/BOB/src/net/i2p/BOB/I2PtoTCP.java +++ b/apps/BOB/src/net/i2p/BOB/I2PtoTCP.java @@ -32,9 +32,9 @@ import net.i2p.util.I2PAppThread; public class I2PtoTCP implements Runnable { private I2PSocket I2P; - private NamedDB info, database; + private final NamedDB info, database; private Socket sock; - private AtomicBoolean lives; + private final AtomicBoolean lives; /** * Constructor diff --git a/apps/BOB/src/net/i2p/BOB/MUXlisten.java b/apps/BOB/src/net/i2p/BOB/MUXlisten.java index 81dbe0845..8c2df4dfb 100644 --- a/apps/BOB/src/net/i2p/BOB/MUXlisten.java +++ b/apps/BOB/src/net/i2p/BOB/MUXlisten.java @@ -38,18 +38,18 @@ import net.i2p.util.Log; */ public class MUXlisten implements Runnable { - private NamedDB database, info; - private Logger _log; - private I2PSocketManager socketManager; - private ByteArrayInputStream prikey; + private final NamedDB database, info; + private final Logger _log; + private final I2PSocketManager socketManager; + private final ByteArrayInputStream prikey; private ThreadGroup tg; - private String N; - private ServerSocket listener = null; - private int backlog = 50; // should this be more? less? - boolean go_out; - boolean come_in; - private AtomicBoolean lock; - private AtomicBoolean lives; + private final String N; + private ServerSocket listener; + private final int backlog = 50; // should this be more? less? + private final boolean go_out; + private final boolean come_in; + private final AtomicBoolean lock; + private final AtomicBoolean lives; /** * Constructor Will fail if INPORT is occupied. @@ -61,16 +61,15 @@ public class MUXlisten implements Runnable { * @throws java.io.IOException */ MUXlisten(AtomicBoolean lock, NamedDB database, NamedDB info, Logger _log) throws I2PException, IOException, RuntimeException { + int port = 0; + InetAddress host = null; + this.lock = lock; + this.tg = null; + this.database = database; + this.info = info; + this._log = _log; + lives = new AtomicBoolean(false); try { - int port = 0; - InetAddress host = null; - this.lock = lock; - this.tg = null; - this.database = database; - this.info = info; - this._log = _log; - lives = new AtomicBoolean(false); - this.database.getWriteLock(); this.info.getWriteLock(); this.info.add("STARTING", Boolean.valueOf(true)); diff --git a/apps/BOB/src/net/i2p/BOB/TCPio.java b/apps/BOB/src/net/i2p/BOB/TCPio.java index f54cb574e..5a8a09fcf 100644 --- a/apps/BOB/src/net/i2p/BOB/TCPio.java +++ b/apps/BOB/src/net/i2p/BOB/TCPio.java @@ -27,9 +27,9 @@ import java.util.concurrent.atomic.AtomicBoolean; */ public class TCPio implements Runnable { - private InputStream Ain; - private OutputStream Aout; - private AtomicBoolean lives; + private final InputStream Ain; + private final OutputStream Aout; + private final AtomicBoolean lives; /** * Constructor diff --git a/apps/BOB/src/net/i2p/BOB/TCPtoI2P.java b/apps/BOB/src/net/i2p/BOB/TCPtoI2P.java index 3f196af28..833ae652b 100644 --- a/apps/BOB/src/net/i2p/BOB/TCPtoI2P.java +++ b/apps/BOB/src/net/i2p/BOB/TCPtoI2P.java @@ -42,10 +42,10 @@ import net.i2p.util.I2PAppThread; public class TCPtoI2P implements Runnable { private I2PSocket I2P; - private NamedDB info, database; - private Socket sock; - private I2PSocketManager socketManager; - private AtomicBoolean lives; + private final NamedDB info, database; + private final Socket sock; + private final I2PSocketManager socketManager; + private final AtomicBoolean lives; /** * Constructor