From 7b294811249cff2cce3ac4166a97719383f72d09 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Tue, 1 Mar 2011 13:37:40 +0000
Subject: [PATCH] updates after review

---
 apps/i2psnark/java/src/org/klomp/snark/I2PSnarkUtil.java     | 2 +-
 apps/i2psnark/java/src/org/klomp/snark/MagnetState.java      | 4 ++--
 apps/i2psnark/java/src/org/klomp/snark/SnarkManager.java     | 2 +-
 apps/i2psnark/java/src/org/klomp/snark/dht/DHT.java          | 2 +-
 .../java/src/org/klomp/snark/web/I2PSnarkServlet.java        | 5 +++--
 core/java/src/net/i2p/stat/StatManager.java                  | 2 +-
 6 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/apps/i2psnark/java/src/org/klomp/snark/I2PSnarkUtil.java b/apps/i2psnark/java/src/org/klomp/snark/I2PSnarkUtil.java
index 13bda2e55..6f35f66bd 100644
--- a/apps/i2psnark/java/src/org/klomp/snark/I2PSnarkUtil.java
+++ b/apps/i2psnark/java/src/org/klomp/snark/I2PSnarkUtil.java
@@ -134,7 +134,7 @@ public class I2PSnarkUtil {
     }
     
     /**
-     *  @param KBps
+     *  @param limit KBps
      */
     public void setMaxUpBW(int limit) {
         _maxUpBW = limit;
diff --git a/apps/i2psnark/java/src/org/klomp/snark/MagnetState.java b/apps/i2psnark/java/src/org/klomp/snark/MagnetState.java
index e9eb56389..f19f1091a 100644
--- a/apps/i2psnark/java/src/org/klomp/snark/MagnetState.java
+++ b/apps/i2psnark/java/src/org/klomp/snark/MagnetState.java
@@ -57,7 +57,7 @@ class MagnetState {
     }
 
     /**
-     *  @param call this for a new magnet when you have the size
+     *  Call this for a new magnet when you have the size
      *  @throws IllegalArgumentException
      */
     public void initialize(int size) {
@@ -77,7 +77,7 @@ class MagnetState {
     }
 
     /**
-     *  @param Call this for a new magnet when the download is complete.
+     *  Call this for a new magnet when the download is complete.
      *  @throws IllegalArgumentException
      */
     public void setMetaInfo(MetaInfo meta) {
diff --git a/apps/i2psnark/java/src/org/klomp/snark/SnarkManager.java b/apps/i2psnark/java/src/org/klomp/snark/SnarkManager.java
index 29c6a1ed2..e47ffcc0c 100644
--- a/apps/i2psnark/java/src/org/klomp/snark/SnarkManager.java
+++ b/apps/i2psnark/java/src/org/klomp/snark/SnarkManager.java
@@ -644,7 +644,7 @@ public class SnarkManager implements Snark.CompleteListener {
      * @param name hex or b32 name from the magnet link
      * @param ih 20 byte info hash
      * @param trackerURL may be null
-     * @param udpateStatus should we add this magnet to the config file,
+     * @param updateStatus should we add this magnet to the config file,
      *                     to save it across restarts, in case we don't get
      *                     the metadata before shutdown?
      * @throws RuntimeException via Snark.fatal()
diff --git a/apps/i2psnark/java/src/org/klomp/snark/dht/DHT.java b/apps/i2psnark/java/src/org/klomp/snark/dht/DHT.java
index a074890b9..6a16e4e60 100644
--- a/apps/i2psnark/java/src/org/klomp/snark/dht/DHT.java
+++ b/apps/i2psnark/java/src/org/klomp/snark/dht/DHT.java
@@ -54,7 +54,7 @@ public interface DHT {
      *  Non-blocking.
      *
      *  @param ih the Info Hash (torrent)
-     *  @param peer the peer's Hash
+     *  @param peerHash the peer's Hash
      */
     public void announce(byte[] ih, byte[] peerHash);
 
diff --git a/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java b/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java
index 92a82de3e..788741bd8 100644
--- a/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java
+++ b/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java
@@ -353,7 +353,7 @@ public class I2PSnarkServlet extends Default {
         boolean isDegraded = ua != null && (ua.startsWith("Lynx") || ua.startsWith("w3m") ||
                                             ua.startsWith("ELinks") || ua.startsWith("Dillo"));
 
-        boolean noThinsp = isDegraded || ua.startsWith("Opera");
+        boolean noThinsp = isDegraded || (ua != null && ua.startsWith("Opera"));
         if (_manager.util().connected()) {
             if (isDegraded)
                 out.write("<a href=\"/i2psnark/?action=StopAll&amp;nonce=" + _nonce + "\"><img title=\"");
@@ -1883,7 +1883,8 @@ public class I2PSnarkServlet extends Default {
             mime = "";
         if (mime.equals("text/html"))
             icon = "html";
-        else if (mime.equals("text/plain") || plc.endsWith(".nfo"))
+        else if (mime.equals("text/plain") || plc.endsWith(".nfo") ||
+                 mime.equals("application/rtf"))
             icon = "page";
         else if (mime.equals("application/java-archive") || plc.endsWith(".war") ||
                  plc.endsWith(".deb"))
diff --git a/core/java/src/net/i2p/stat/StatManager.java b/core/java/src/net/i2p/stat/StatManager.java
index 531138d1a..868e18402 100644
--- a/core/java/src/net/i2p/stat/StatManager.java
+++ b/core/java/src/net/i2p/stat/StatManager.java
@@ -54,7 +54,7 @@ public class StatManager {
         "jobQueue.jobLag,netDb.successTime,peer.failedLookupRate,router.fastPeers," +
         "prng.bufferFillTime,prng.bufferWaitTime,router.memoryUsed," +
         "transport.receiveMessageSize,transport.sendMessageSize,transport.sendProcessingTime," +
-        "tunnel.acceptLoad,tunnel.buildRequestTime,tunnel.rejectOverloaded,tunnel.rejectTimeout" +
+        "tunnel.acceptLoad,tunnel.buildRequestTime,tunnel.rejectOverloaded,tunnel.rejectTimeout," +
         "tunnel.buildClientExpire,tunnel.buildClientReject,tunnel.buildClientSuccess," +
         "tunnel.buildExploratoryExpire,tunnel.buildExploratoryReject,tunnel.buildExploratorySuccess," +
         "tunnel.buildRatio.*,tunnel.corruptMessage,tunnel.dropLoad*," +