diff --git a/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java b/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java index a9fffb910..a9aafca15 100644 --- a/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java +++ b/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java @@ -2134,7 +2134,7 @@ public class I2PSnarkServlet extends BasicServlet { host = Base32.encode(h.getData()) + ".b32.i2p" + port; } } - buf.append(""); + buf.append(""); } // strip port int colon = announce.indexOf(':'); @@ -2288,7 +2288,7 @@ public class I2PSnarkServlet extends BasicServlet { boolean noCollapse = noCollapsePanels(req); - out.write("
\n" + + out.write("\n" + "
\n"); writeHiddenInputs(out, req, "Save"); out.write(""); @@ -2986,9 +2986,9 @@ public class I2PSnarkServlet extends BasicServlet { announce = DataHelper.stripHTML(announce); buf.append(""); toThemeImg(buf, "details"); - buf.append("").append(_t("Primary Tracker")).append(": "); + buf.append("").append(_t("Primary Tracker")).append(": "); buf.append(getShortTrackerLink(announce, snark.getInfoHash())); - buf.append(""); + buf.append(""); } List> alist = meta.getAnnounceList(); if (alist != null && !alist.isEmpty()) { @@ -2997,7 +2997,7 @@ public class I2PSnarkServlet extends BasicServlet { buf.append("") .append(_t("Tracker List")).append(": "); for (List alist2 : alist) { - buf.append('['); + buf.append(""); boolean more = false; for (String s : alist2) { if (more) @@ -3006,7 +3006,7 @@ public class I2PSnarkServlet extends BasicServlet { more = true; buf.append(getShortTrackerLink(DataHelper.stripHTML(s), snark.getInfoHash())); } - buf.append("] "); + buf.append(" "); } buf.append("\n"); } @@ -3406,14 +3406,16 @@ public class I2PSnarkServlet extends BasicServlet { path=addPaths(path,"/"); path = encodePath(path); String icon = toIcon(item); + String mime = getMimeType(path); + if (mime == null) + mime = ""; buf.append(""); if (complete) { buf.append(""); // thumbnail ? String plc = item.toString().toLowerCase(Locale.US); - if (plc.endsWith(".jpg") || plc.endsWith(".jpeg") || plc.endsWith(".png") || - plc.endsWith(".gif") || plc.endsWith(".ico")) { + if (mime.startsWith("image/")) { buf.append("\"\""); } else { @@ -3423,8 +3425,17 @@ public class I2PSnarkServlet extends BasicServlet { buf.append(toImg(icon)); } buf.append(""); - if (complete) - buf.append(""); + if (complete) { + buf.append(""); + } buf.append(DataHelper.escapeHTML(item.getName())); if (complete) buf.append(""); diff --git a/history.txt b/history.txt index 8e2255d3d..bdeef3ecd 100644 --- a/history.txt +++ b/history.txt @@ -3,6 +3,12 @@ - Sidebar: - Fix erratic display of sidebar graph - Add id to memory bar so we can target it for Chrome/blink display issue + * I2PSnark: + - Roll back target="_top" in config page to prevent embedded view from + breaking out of iframe + - Add target="_blank" to relevant links to avoid display in iframe in + embedded mode + - Enhance presentation of tracker links in TorrentInfo view 2017-10-25 str4d * Console: