diff --git a/apps/routerconsole/java/src/net/i2p/router/web/ConfigTunnelsHelper.java b/apps/routerconsole/java/src/net/i2p/router/web/ConfigTunnelsHelper.java index d3579f17c..de988279f 100644 --- a/apps/routerconsole/java/src/net/i2p/router/web/ConfigTunnelsHelper.java +++ b/apps/routerconsole/java/src/net/i2p/router/web/ConfigTunnelsHelper.java @@ -18,17 +18,24 @@ public class ConfigTunnelsHelper extends HelperBase { public String getForm() { StringBuilder buf = new StringBuilder(1024); + // HTML: cannot be inside a + buf.append("\n"); + int cur = 1; + Set clients = _context.clientManager().listClients(); + for (Destination dest : clients) { + buf.append("\n"); + cur++; + } + buf.append("
\n"); TunnelPoolSettings exploratoryIn = _context.tunnelManager().getInboundSettings(); TunnelPoolSettings exploratoryOut = _context.tunnelManager().getOutboundSettings(); - buf.append(""); renderForm(buf, 0, "exploratory", _("Exploratory tunnels"), exploratoryIn, exploratoryOut); - int cur = 1; - Set clients = _context.clientManager().listClients(); - for (Iterator iter = clients.iterator(); iter.hasNext(); ) { - Destination dest = (Destination)iter.next(); + cur = 1; + for (Destination dest : clients) { TunnelPoolSettings in = _context.tunnelManager().getInboundSettings(dest.calculateHash()); TunnelPoolSettings out = _context.tunnelManager().getOutboundSettings(dest.calculateHash()); @@ -41,9 +48,7 @@ public class ConfigTunnelsHelper extends HelperBase { name = dest.calculateHash().toBase64().substring(0,6); String prefix = dest.calculateHash().toBase64().substring(0,4); - buf.append(""); - renderForm(buf, cur, prefix, _("Client tunnels for") + " " + _(name), in, out); + renderForm(buf, cur, prefix, _("Client tunnels for {0}", _(name)), in, out); cur++; } diff --git a/apps/routerconsole/java/src/net/i2p/router/web/ConfigUpdateHelper.java b/apps/routerconsole/java/src/net/i2p/router/web/ConfigUpdateHelper.java index 2e03ad93f..10b587db6 100644 --- a/apps/routerconsole/java/src/net/i2p/router/web/ConfigUpdateHelper.java +++ b/apps/routerconsole/java/src/net/i2p/router/web/ConfigUpdateHelper.java @@ -82,7 +82,7 @@ public class ConfigUpdateHelper extends HelperBase { for (int i = 0; i < PERIODS.length; i++) { buf.append("\n"); diff --git a/apps/routerconsole/java/src/net/i2p/router/web/ShitlistRenderer.java b/apps/routerconsole/java/src/net/i2p/router/web/ShitlistRenderer.java index 12c667872..967981130 100644 --- a/apps/routerconsole/java/src/net/i2p/router/web/ShitlistRenderer.java +++ b/apps/routerconsole/java/src/net/i2p/router/web/ShitlistRenderer.java @@ -43,6 +43,11 @@ public class ShitlistRenderer { Map entries = new TreeMap(new HashComparator()); entries.putAll(_context.shitlist().getEntries()); + if (entries.isEmpty()) { + buf.append("").append(_("none")).append(""); + out.write(buf.toString()); + return; + } buf.append("
+
<% while (statshelper.hasMoreStats()) { while (statshelper.groupRequired()) { %> - @@ -93,11 +97,11 @@ function toggleAll(category) } // end iterating over required groups for the current stat %> <% @@ -110,4 +114,4 @@ function toggleAll(category) " > " > -
+ > <%=statshelper.getCurrentGroupName()%> - (<%=intl._("toggle all")%>) + (<%=intl._("toggle all")%>)
<%=intl._("Log")%>
- checked="true" <% } %> > <% if (statshelper.getCurrentCanBeGraphed()) { %> - checked="true" <% } %> ><% } %> <%=statshelper.getCurrentStatName()%>:
<%=statshelper.getCurrentStatDescription()%>

+ diff --git a/apps/routerconsole/jsp/configtunnels.jsp b/apps/routerconsole/jsp/configtunnels.jsp index 6e22b1e2d..15c266d8c 100644 --- a/apps/routerconsole/jsp/configtunnels.jsp +++ b/apps/routerconsole/jsp/configtunnels.jsp @@ -41,4 +41,4 @@ " > " > -

+