zzz/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* Console, i2ptunnel: Warn on low ports

Browse Source
This commit is contained in:
zzz
2012-10-09 10:13:10 +00:00
parent e99dd72cb6
commit 23c77fbe4b
2 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
apps/i2ptunnel/java/src/net/i2p/i2ptunnel/web/IndexBean.java
View File

@@ -458,8 +458,13 @@ public class IndexBean {
String port = tun.getListenPort(); String port = tun.getListenPort();
if (port.length() == 0) if (port.length() == 0)
return "<font color=\"red\">" + _("Port not set") + "</font>"; return "<font color=\"red\">" + _("Port not set") + "</font>";
if (Addresses.getPort(port) == 0) int iport = Addresses.getPort(port);
if (iport == 0)
return "<font color=\"red\">" + _("Invalid port") + ' ' + port + "</font>"; return "<font color=\"red\">" + _("Invalid port") + ' ' + port + "</font>";
if (iport < 1024)
return "<font color=\"red\">" +
_("Warning - ports less than 1024 are not recommended") +
": " + port + "</font>";
return port; return port;
} }
return "<font color=\"red\">" + _("Port not set") + "</font>"; return "<font color=\"red\">" + _("Port not set") + "</font>";

17
apps/routerconsole/java/src/net/i2p/router/web/ConfigNetHandler.java
View File

@@ -216,9 +216,14 @@ public class ConfigNetHandler extends FormHandler {
} }
if (oldAutoPort != _ntcpAutoPort || ! oldNPort.equals(_ntcpPort)) { if (oldAutoPort != _ntcpAutoPort || ! oldNPort.equals(_ntcpPort)) {
if (_ntcpPort.length() > 0 && !_ntcpAutoPort) { if (_ntcpPort.length() > 0 && !_ntcpAutoPort) {
if (Addresses.getPort(_ntcpPort) != 0) { int port = Addresses.getPort(_ntcpPort);
if (port != 0) {
changes.put(ConfigNetHelper.PROP_I2NP_NTCP_PORT, _ntcpPort); changes.put(ConfigNetHelper.PROP_I2NP_NTCP_PORT, _ntcpPort);
addFormNotice(_("Updating TCP port to {0}", _ntcpPort)); addFormNotice(_("Updating TCP port to {0}", _ntcpPort));
if (port < 1024) {
addFormError(_("Warning - ports less than 1024 are not recommended"));
error = true;
}
} else { } else {
addFormError(_("Invalid port") + ": " + _ntcpPort); addFormError(_("Invalid port") + ": " + _ntcpPort);
error = true; error = true;
@@ -235,11 +240,17 @@ public class ConfigNetHandler extends FormHandler {
if ( (_udpPort != null) && (_udpPort.length() > 0) ) { if ( (_udpPort != null) && (_udpPort.length() > 0) ) {
String oldPort = _context.getProperty(UDPTransport.PROP_INTERNAL_PORT, "unset"); String oldPort = _context.getProperty(UDPTransport.PROP_INTERNAL_PORT, "unset");
if (!oldPort.equals(_udpPort)) { if (!oldPort.equals(_udpPort)) {
if (Addresses.getPort(_udpPort) != 0) { int port = Addresses.getPort(_udpPort);
if (port != 0) {
changes.put(UDPTransport.PROP_INTERNAL_PORT, _udpPort); changes.put(UDPTransport.PROP_INTERNAL_PORT, _udpPort);
changes.put(UDPTransport.PROP_EXTERNAL_PORT, _udpPort); changes.put(UDPTransport.PROP_EXTERNAL_PORT, _udpPort);
addFormNotice(_("Updating UDP port to {0}", _udpPort)); addFormNotice(_("Updating UDP port to {0}", _udpPort));
restartRequired = true; if (port < 1024) {
addFormError(_("Warning - ports less than 1024 are not recommended"));
error = true;
} else {
restartRequired = true;
}
} else { } else {
addFormError(_("Invalid port") + ": " + _udpPort); addFormError(_("Invalid port") + ": " + _udpPort);
error = true; error = true;