- Don't start UPnP if we have a public interface address

- Fix setting IP to a local interface address
- Work on the configuration help some more
This commit is contained in:
zzz
2009-05-10 15:40:50 +00:00
parent ee7e70b98a
commit 47fc3b0d0b
3 changed files with 43 additions and 21 deletions

View File

@@ -131,7 +131,12 @@ public class TransportManager implements TransportEventListener {
}
public void startListening() {
if (_upnpManager != null)
// For now, only start UPnP if we have no publicly-routable addresses
// so we don't open the listener ports to the world.
// Maybe we need a config option to force on? Probably not.
// What firewall supports UPnP and is configured with a public address on the LAN side?
// Unlikely.
if (_upnpManager != null && Addresses.getAnyAddress() == null)
_upnpManager.start();
configTransports();
_log.debug("Starting up the transport manager");