diff --git a/apps/routerconsole/java/src/net/i2p/router/web/ConfigPeerHandler.java b/apps/routerconsole/java/src/net/i2p/router/web/ConfigPeerHandler.java index 68f46d204..48ec6e443 100644 --- a/apps/routerconsole/java/src/net/i2p/router/web/ConfigPeerHandler.java +++ b/apps/routerconsole/java/src/net/i2p/router/web/ConfigPeerHandler.java @@ -20,22 +20,22 @@ public class ConfigPeerHandler extends FormHandler { if ("Save Configuration".equals(_action)) { _context.router().saveConfig(); addFormNotice("Settings saved - not really!!!!!"); - } else if (_action.startsWith("Shitlist")) { + } else if (_action.startsWith("Ban")) { Hash h = getHash(); if (h != null) { - _context.shitlist().shitlistRouterForever(h, "Manually shitlisted via configpeer.jsp"); - addFormNotice("Peer " + _peer + " shitlisted forever"); + _context.shitlist().shitlistRouterForever(h, "Manually banned via configpeer.jsp"); + addFormNotice("Peer " + _peer + " banned until restart"); return; } addFormError("Invalid peer"); - } else if (_action.startsWith("Unshitlist")) { + } else if (_action.startsWith("Unban")) { Hash h = getHash(); if (h != null) { if (_context.shitlist().isShitlisted(h)) { _context.shitlist().unshitlistRouter(h); - addFormNotice("Peer " + _peer + " unshitlisted"); + addFormNotice("Peer " + _peer + " unbanned"); } else - addFormNotice("Peer " + _peer + " is not currently shitlisted"); + addFormNotice("Peer " + _peer + " is not currently banned"); return; } addFormError("Invalid peer"); diff --git a/apps/routerconsole/jsp/configpeer.jsp b/apps/routerconsole/jsp/configpeer.jsp index f16462807..77095fdce 100644 --- a/apps/routerconsole/jsp/configpeer.jsp +++ b/apps/routerconsole/jsp/configpeer.jsp @@ -39,11 +39,11 @@

Manual Peer Controls

Router Hash: -

Manually Shitlist / Unshitlist a Router

+

Manually Ban / Unban a Peer

Shitlisting will prevent the participation of this peer in tunnels you create.

- - + + <% if (! "".equals(peer)) { %> <---- click to verify action <% } %> diff --git a/router/java/src/net/i2p/router/Blocklist.java b/router/java/src/net/i2p/router/Blocklist.java index 1ce5cb5e7..b61f04d2e 100644 --- a/router/java/src/net/i2p/router/Blocklist.java +++ b/router/java/src/net/i2p/router/Blocklist.java @@ -111,7 +111,7 @@ public class Blocklist { } for (Iterator iter = _peerBlocklist.keySet().iterator(); iter.hasNext(); ) { Hash peer = (Hash) iter.next(); - String reason = "Blocklisted by router hash"; + String reason = "Banned by router hash"; String comment = (String) _peerBlocklist.get(peer); if (comment != null) reason = reason + ": " + comment; @@ -659,7 +659,7 @@ public class Blocklist { */ public void shitlist(Hash peer) { // Temporary reason, until the job finishes - _context.shitlist().shitlistRouterForever(peer, "IP Blocklisted"); + _context.shitlist().shitlistRouterForever(peer, "IP Banned"); if (! "true".equals( _context.getProperty(PROP_BLOCKLIST_DETAIL, "true"))) return; boolean shouldRunJob; @@ -682,7 +682,7 @@ public class Blocklist { super(_context); _peer = p; } - public String getName() { return "Shitlist Peer Forever"; } + public String getName() { return "Ban Peer by IP"; } public void runJob() { shitlistForever(_peer); synchronized (_inProcess) { @@ -735,7 +735,7 @@ public class Blocklist { if (i != 3) reason = reason + '.'; } - reason = reason + " blocklisted by entry \"" + buf + "\""; + reason = reason + " banned by " + BLOCKLIST_FILE_DEFAULT + " entry \"" + buf + "\""; if (_log.shouldLog(Log.WARN)) _log.warn("Shitlisting " + peer + " " + reason); _context.shitlist().shitlistRouterForever(peer, reason); @@ -755,7 +755,7 @@ public class Blocklist { /** write directly to the stream so we don't OOM on a huge list */ public void renderStatusHTML(Writer out) throws IOException { - out.write("

IP Blocklist

"); + out.write("

Banned IPs

"); Set singles = new TreeSet(); singles.addAll(_singleIPBlocklist); if (singles.size() > 0) { diff --git a/router/java/src/net/i2p/router/Shitlist.java b/router/java/src/net/i2p/router/Shitlist.java index 6f38826b3..d1307fdea 100644 --- a/router/java/src/net/i2p/router/Shitlist.java +++ b/router/java/src/net/i2p/router/Shitlist.java @@ -65,7 +65,7 @@ public class Shitlist { _toUnshitlist = new ArrayList(4); getTiming().setStartAfter(ctx.clock().now() + SHITLIST_CLEANER_START_DELAY); } - public String getName() { return "Cleanup shitlist"; } + public String getName() { return "Expire banned peers"; } public void runJob() { _toUnshitlist.clear(); long now = getContext().clock().now(); @@ -253,7 +253,7 @@ public class Shitlist { public void renderStatusHTML(Writer out) throws IOException { StringBuilder buf = new StringBuilder(1024); - buf.append("

Shitlist

"); + buf.append("

Banned Peers

"); Map entries = new TreeMap(new HashComparator()); entries.putAll(_entries); @@ -273,7 +273,7 @@ public class Shitlist { buf.append("
\n"); buf.append(entry.cause); } - buf.append(" (unshitlist now)"); + buf.append(" (unban now)"); buf.append("\n"); } buf.append("\n"); diff --git a/router/java/src/net/i2p/router/peermanager/ProfileOrganizerRenderer.java b/router/java/src/net/i2p/router/peermanager/ProfileOrganizerRenderer.java index ebb9d61c0..c7a66e528 100644 --- a/router/java/src/net/i2p/router/peermanager/ProfileOrganizerRenderer.java +++ b/router/java/src/net/i2p/router/peermanager/ProfileOrganizerRenderer.java @@ -138,7 +138,7 @@ class ProfileOrganizerRenderer { } buf.append("").append(num(prof.getIntegrationValue())); buf.append(""); - if (_context.shitlist().isShitlisted(peer)) buf.append("Shitlist"); + if (_context.shitlist().isShitlisted(peer)) buf.append("Banned"); if (prof.getIsFailing()) buf.append(" Failing"); if (_context.commSystem().wasUnreachable(peer)) buf.append(" Unreachable"); Rate failed = prof.getTunnelHistory().getFailedRate().getRate(30*60*1000);