From 5b603d6627f7742b50f5f2c5051b3a76a4fa29cf Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Mon, 8 Mar 2010 22:17:46 +0000
Subject: [PATCH] cleanups and comments

---
 .../java/src/net/i2p/router/tunnel/TrivialPreprocessor.java   | 4 ++--
 router/java/src/net/i2p/router/tunnel/TunnelDispatcher.java   | 1 +
 .../src/net/i2p/router/tunnel/pool/TunnelPeerSelector.java    | 3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/router/java/src/net/i2p/router/tunnel/TrivialPreprocessor.java b/router/java/src/net/i2p/router/tunnel/TrivialPreprocessor.java
index 0e32f0f93..3dac4dd20 100644
--- a/router/java/src/net/i2p/router/tunnel/TrivialPreprocessor.java
+++ b/router/java/src/net/i2p/router/tunnel/TrivialPreprocessor.java
@@ -101,7 +101,7 @@ public class TrivialPreprocessor implements TunnelGateway.QueuePreprocessor {
      * @deprecated unused except by above
      */
     private byte[][] preprocess(TunnelGateway.Pending msg) {
-        List fragments = new ArrayList(1);
+        List<byte[]> fragments = new ArrayList(1);
 
         while (msg.getOffset() < msg.getData().length) {
             fragments.add(preprocessFragment(msg));
@@ -111,7 +111,7 @@ public class TrivialPreprocessor implements TunnelGateway.QueuePreprocessor {
 
         byte rv[][] = new byte[fragments.size()][];
         for (int i = 0; i < fragments.size(); i++)
-            rv[i] = (byte[])fragments.get(i);
+            rv[i] = fragments.get(i);
         return rv;
     }
     
diff --git a/router/java/src/net/i2p/router/tunnel/TunnelDispatcher.java b/router/java/src/net/i2p/router/tunnel/TunnelDispatcher.java
index 05721d0fb..2644cf330 100644
--- a/router/java/src/net/i2p/router/tunnel/TunnelDispatcher.java
+++ b/router/java/src/net/i2p/router/tunnel/TunnelDispatcher.java
@@ -726,6 +726,7 @@ public class TunnelDispatcher implements Service {
         startup(); 
     }
     
+    /** @deprecated moved to router console */
     public void renderStatusHTML(Writer out) throws IOException {}    
     
     private class LeaveTunnel extends JobImpl {
diff --git a/router/java/src/net/i2p/router/tunnel/pool/TunnelPeerSelector.java b/router/java/src/net/i2p/router/tunnel/pool/TunnelPeerSelector.java
index a3b5c4b20..b2343aedb 100644
--- a/router/java/src/net/i2p/router/tunnel/pool/TunnelPeerSelector.java
+++ b/router/java/src/net/i2p/router/tunnel/pool/TunnelPeerSelector.java
@@ -180,7 +180,8 @@ public abstract class TunnelPeerSelector {
         peers.addAll(ctx.tunnelManager().selectPeersInTooManyTunnels());
         // if (false && filterUnreachable(ctx, isInbound, isExploratory)) {
         if (filterUnreachable(ctx, isInbound, isExploratory)) {
-            List caps = ctx.peerManager().getPeersByCapability(Router.CAPABILITY_UNREACHABLE);
+            // This is the only use for getPeersByCapability? And the whole set of datastructures in PeerManager?
+            List<Hash> caps = ctx.peerManager().getPeersByCapability(Router.CAPABILITY_UNREACHABLE);
             if (caps != null)
                 peers.addAll(caps);
             caps = ctx.profileOrganizer().selectPeersLocallyUnreachable();