From 5decf3cd7a463d91f715b7f0db992b8489b0212b Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Thu, 13 Aug 2009 18:46:14 +0000
Subject: [PATCH] Dont show firewall warning unless its for real

---
 .../java/src/net/i2p/router/web/SummaryHelper.java   | 12 ++++++++++++
 apps/routerconsole/jsp/summarynoframe.jsp            |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/apps/routerconsole/java/src/net/i2p/router/web/SummaryHelper.java b/apps/routerconsole/java/src/net/i2p/router/web/SummaryHelper.java
index 316243c08..6a1473d48 100644
--- a/apps/routerconsole/java/src/net/i2p/router/web/SummaryHelper.java
+++ b/apps/routerconsole/java/src/net/i2p/router/web/SummaryHelper.java
@@ -154,6 +154,18 @@ public class SummaryHelper extends HelperBase {
         else
             return _context.commSystem().countActivePeers();
     }
+
+    /**
+     * Should we warn about a possible firewall problem?
+     */
+    public boolean showFirewallWarning() {
+        return _context != null && 
+               _context.netDb().isInitialized() &&
+               _context.router().getUptime() > 2*60*1000 &&
+               _context.commSystem().countActivePeers() <= 0 &&
+               _context.netDb().getKnownRouters() > 5;
+    }
+
     /**
      * How many active identities have we spoken with recently
      *
diff --git a/apps/routerconsole/jsp/summarynoframe.jsp b/apps/routerconsole/jsp/summarynoframe.jsp
index 2a473d1f5..8c5177d94 100644
--- a/apps/routerconsole/jsp/summarynoframe.jsp
+++ b/apps/routerconsole/jsp/summarynoframe.jsp
@@ -92,7 +92,7 @@
 <tr><td align="left"><b>High capacity:</b></td><td align="right"><jsp:getProperty name="helper" property="highCapacityPeers" /></td></tr>
 <tr><td align="left"><b>Integrated:</b></td><td align="right"><jsp:getProperty name="helper" property="wellIntegratedPeers" /></td></tr>
 <tr><td align="left"><b>Known:</b></td><td align="right"><jsp:getProperty name="helper" property="allPeers" /></td></tr></table><hr><%
-    if (helper.getActivePeers() <= 0) {
+    if (helper.showFirewallWarning()) {
         %><h4><a href="config.jsp" target="_top" title="Help with firewall configuration.">Check NAT/firewall</a></h4><%
     }
     // If showing the reseed link is allowed