From b9dc7ec12efb33253df37682476243e89b185869 Mon Sep 17 00:00:00 2001 From: kytv Date: Fri, 26 Aug 2011 23:25:12 +0000 Subject: [PATCH] Set permissions to a SID not to the group Users, fixing a bug that is triggered on localized versions of Windows. ---- Non-English versions of Windows do not have a Users group; instead they use a localized group name. As a result, when installing I2P on a non-English Windows box, the installer will show an error when trying to run the fixperms.bat script. Using the SID will work with any localized Windows. SID list @ http://support.microsoft.com/kb/243330/en-us --- installer/resources/fixperms.bat | 30 +++++++++++++++++++----------- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/installer/resources/fixperms.bat b/installer/resources/fixperms.bat index 75cb715ab..853f0682b 100755 --- a/installer/resources/fixperms.bat +++ b/installer/resources/fixperms.bat @@ -1,11 +1,19 @@ -:: Fix Vista permission problems -:: From http://www.nabble.com/Classpath-security-issues-on-Vista-td22456230.html -:: -:: 'echo Y' to get past the 'are you sure' question... -:: cacls requires it on XP, icacls doesnt appear so, but can't hurt -:: F : full control -:: /c : continue on error -:: /q : quiet -:: /t : recursive -:: -echo Y|icacls %1 /grant Users:F /c /t > %1%\fixperms.log +:: Fix Vista permission problems +:: From http://www.nabble.com/Classpath-security-issues-on-Vista-td22456230.html +:: +:: 'echo Y' to get past the 'are you sure' question... +:: cacls requires it on XP, icacls doesnt appear so, but can't hurt +:: F : full control +:: /c : continue on error +:: /q : quiet +:: /t : recursive +:: +:: Note: We should not use the group name "Users" since this group will not +:: exist on non-English versions of Windows. +:: +:: S-1-5-32-545 = Users (en). Benutzer (de), etc. +:: +:: Specifying the SID will work on ALL versions of Windows. +:: List of well-known SIDs at http://support.microsoft.com/kb/243330/en-us +:: +echo Y|icacls %1 /grant *S-1-5-32-545:F /c /t > %1%\fixperms.log