Findbugs all over #3

char encoding, remove FileReader/FileWriter
Fix TunnelConfig bug
This commit is contained in:
zzz
2015-07-12 16:34:24 +00:00
parent 1f9bb046f5
commit d087fd674b
6 changed files with 15 additions and 11 deletions

View File

@@ -35,7 +35,6 @@ import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.FileReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
@@ -1605,7 +1604,7 @@ public class I2PTunnel extends EventDispatcherImpl implements Logging {
private void runRun(String args[], Logging l) {
if (args.length == 1) {
try {
BufferedReader br = new BufferedReader(new FileReader(args[0]));
BufferedReader br = new BufferedReader(new InputStreamReader(new FileInputStream(args[0]), "UTF-8"));
String line;
while ((line = br.readLine()) != null) {
runCommand(line, l);

View File

@@ -4,8 +4,9 @@
package net.i2p.i2ptunnel;
import java.io.BufferedReader;
import java.io.FileReader;
import java.io.FileInputStream;
import java.io.IOException;
import java.io.InputStreamReader;
import java.net.Socket;
import java.util.ArrayList;
import java.util.List;
@@ -157,7 +158,7 @@ public class I2Ping extends I2PTunnelClientBase {
}
if (hostListFile != null) {
BufferedReader br = new BufferedReader(new FileReader(hostListFile));
BufferedReader br = new BufferedReader(new InputStreamReader(new FileInputStream(hostListFile), "UTF-8"));
String line;
List<PingHandler> pingHandlers = new ArrayList<PingHandler>();
int i = 0;

View File

@@ -319,7 +319,7 @@ public class TunnelConfig {
if (val)
_booleanOptions.add(I2PTunnelHTTPClient.PROP_ACCEPT);
else
_booleanOptions.add(I2PTunnelHTTPClient.PROP_ACCEPT);
_booleanOptions.remove(I2PTunnelHTTPClient.PROP_ACCEPT);
}
public void setAllowInternalSSL(boolean val) {
if (val)