Add release notes to release CI description

.github/workflows/ant.yml

@@ -31,7 +31,7 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: I2P-Easy-Install-Bundle-unsigned.exe
-          path: I2P-Easy-Install-Bundle-2.4.0.exe
+          path: I2P-Easy-Install-Bundle-*.exe
 
   buildjpackagexe:
     runs-on: windows-latest
@@ -48,7 +48,7 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: I2P-EXE-unsigned.exe
-          path: I2P-EXE-2.4.0.exe
+          path: I2P-EXE-*.exe
 
   buildjpackagmsi:
     runs-on: windows-latest
@@ -65,7 +65,7 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: I2P-MSI-unsigned.msi
-          path: I2P-MSI-2.4.0.msi
+          path: I2P-MSI-*.msi
 
   buildzip:
     runs-on: windows-latest
@@ -81,7 +81,8 @@ jobs:
           git config --global user.name "eyedeekay Github CI Build"
       - uses: actions/checkout@v4
       - run: wsl apt-get update
-      - run: wsl apt-get install -y nsis nsis-common nsis-pluginapi wget dos2unix curl jq gpg gettext zip
+      - run: wsl apt-cache search 7zip
+      - run: wsl apt-get install -y nsis nsis-common nsis-pluginapi wget dos2unix curl jq gpg gettext zip p7zip-full ca-certificates
       - run: choco install wget
       - name: Set up JDK 21
         uses: actions/setup-java@v4
@@ -89,7 +90,7 @@ jobs:
           java-version: '21'
           distribution: 'temurin'
       - name: build with script
-        run: bash -c "./buildscripts/zip.sh; ls *.zip"
+        run: bash -c "./buildscripts/zip.sh; ls -d * */* "
       - name: Upload I2P-windows-portable.zip
         uses: actions/upload-artifact@v4
         with:

.github/workflows/release.yml

@@ -18,10 +18,20 @@ jobs:
       - uses: actions/checkout@v4
         with:
           sparse-checkout: |
-            changelog.txt
+            changelog.txt docs/RELEASE.md
           sparse-checkout-cone-mode: false
       - name: sleep 15 minutes
         run: |
+          echo "sleeping 20 minutes to wait for artifacts"
+          sleep 1m
+          echo "sleeping 19 minutes to wait for artifacts"
+          sleep 1m
+          echo "sleeping 18 minutes to wait for artifacts"
+          sleep 1m
+          echo "sleeping 17 minutes to wait for artifacts"
+          sleep 1m
+          echo "sleeping 16 minutes to wait for artifacts"
+          sleep 1m
           echo "sleeping 15 minutes to wait for artifacts"
           sleep 1m
           echo "sleeping 14 minutes to wait for artifacts"
@@ -60,7 +70,7 @@ jobs:
           workflow: ant.yml
           if_no_artifact_found: fail
       # remove .zip file extension
-      - run: for f in *.zip; do mv "$f" "${f%.zip}"; done
+      - run: for f in *.zip; do unzip "$f"; rm "$f"; done
       - run: echo "" | tee -a changelog.txt
       - run: echo "## Checksums" | tee -a changelog.txt
       - run: echo "" | tee -a changelog.txt
@@ -68,8 +78,13 @@ jobs:
       - run: sha256sum * | tee -a changelog.txt
       - run: echo '```' | tee -a changelog.txt
       - run: echo "" | tee -a changelog.txt
+      - run: echo '```' | tee -a changelog.txt
+      - run: file * | tee -a changelog.txt
+      - run: echo '```' | tee -a changelog.txt
+      - run: echo "" | tee -a changelog.txt
+      - run: cat docs/RELEASE.md changelog.txt > RELEASE.md
       - name: Upload artifacts
         uses: ncipollo/release-action@v1
         with:
           artifacts: "*"
-          bodyFile: "changelog.txt"
+          bodyFile: "RELEASE.md"

README.md

@@ -1,5 +1,5 @@
-I2P Easy-Install Bundle for Windows(Also/formerly)I2P Browsing Profile for Firefox
-==================================================================================
+I2P Easy-Install Bundle for Windows, (Formerly)I2P Browsing Profile for Firefox
+===============================================================================
 
 Features:
 ---------
@@ -13,6 +13,13 @@ Features:
 Build Dependencies:
 -------------------
 
+**SHORTCUT:** All the build artifacts can be produced by the description in the `.yaml` files in `.github/workflows`.
+These can be run on Github's infrastructure, or on a local(Windows) PC using https://github.com/nektos/act.
+Doing things this way deals with all the dependency issues that Windows doesn't really give you a good way to deal with automatically.
+It also guarantees that the same base container and environment gets used for every build no matter what machine it runs on.
+I highly recommend you use either Github CI or `nektos/act` for dev builds of this software, as it **automates literally every one of the steps**.
+CI-based builds follow the `WSL` version of the instructions.
+
 To build this, you will need the following software packages
 (all available in Debian and Ubuntu, see WSL section below):
 
@@ -166,8 +173,6 @@ set up and you're using git bash, that is enough to make the scripts compatible
         cd i2p.firefox
         ./buildscripts/unsigned.sh
 
-6. Run `make` to build the installer.
-
 Doing a Release
 ---------------
 
@@ -180,53 +185,7 @@ bundle is Zlatinb. Standard Windows signing tools are used.
 ./release.sh
 ```
 
-produces the binary.
-
-Building a signed update file
------------------------------
-
-Building a signed update file for automatically updating a Windows I2P router
-requires you to either be using linux, or have Go installed in your Cygwin or WSL environment.
-On Linux(Where I sign the su3 files), this works:
-
-        make su3
-
-to run the signing tool if necessary and then package the installer in a
-signed update file.
-
-Docker Support
---------------
-
-**MOVED, DEPRECATION NOTICE:** Most of this functionality has been moved
-to http://git.idk.i2p/idk/i2p.plugins.firefox which is more stable,
-easier to build and use, and easier to incorporate into other
-projects.
-
- - https://git.idk.i2p/idk/i2p.plugins.firefox/-/blob/main/docker.sh
-
-Unix Support
-------------
-
-**MOVED. DEPRECATION NOTICE:** Most of this functionality has been moved
-to http://git.idk.i2p/idk/i2p.plugins.firefox which is more stable,
-easier to build and use, and easier to incorporate into other
-projects. It is the better option for nearly every non-Windows case
-right now. You can get binary packages from:
-
- - https://github.com/eyedeekay/i2p.plugins.firefox/releases
-
-or look at
-
- - https://i2pgit.org/idk/i2p.plugins.firefox/-/blob/master/PACKAGES.md
-
-for instructions on how to build your own packages. These packages are
-unofficial! Although I do dogfood most of them and the `.jar` gets thorough
-testing.
-
-**The only remotely interesting Unix functionality that remains in this**
-**repository is the construction of a portable. You can use `targz.sh` to**
-**generate that. Once generated, `cd I2P && ./lib/torbrowser.sh` to complete**
-**setup, and `./bin/I2P` to run it.**
+produces the binary and the su3.
 
 Issues
 ------

buildscripts/launcher.sh

@@ -104,9 +104,16 @@ if [ ! -f "$SCRIPT_DIR/build/jna-platform.jar" ]; then
   wget_download "https://repo1.maven.org/maven2/net/java/dev/jna/jna-platform/$JNA_VERSION/jna-platform-$JNA_VERSION.jar" -O "$SCRIPT_DIR/build/jna-platform.jar"
 fi
 
-if [ ! -f "$SCRIPT_DIR/build/i2pfirefox.jar" ]; then
+if [ ! -f "$SCRIPT_DIR/build/i2pfirefox.zip" ]; then
   echo "downloading i2pfirefox jars"
-  wget_download "https://github.com/eyedeekay/i2p.plugins.firefox/releases/download/$I2PFIREFOX_VERSION/i2pfirefox.jar" -O "$SCRIPT_DIR/build/i2pfirefox.jar"
+  wget_download "https://github.com/eyedeekay/i2p.plugins.firefox/releases/download/$I2PFIREFOX_VERSION/plugin.zip" -O "$SCRIPT_DIR/build/i2pfirefox.zip"
+fi
+
+if [ ! -d "$SCRIPT_DIR/build/I2P/config/plugins/i2pfirefox" ]; then
+  mkdir -p "$SCRIPT_DIR/build/I2P/config/plugins/"
+  unzip "$SCRIPT_DIR/build/i2pfirefox.zip" -d "$SCRIPT_DIR/build/I2P/config/plugins/"
+  rm -rf "$SCRIPT_DIR/build/I2P/config/plugins/i2pfirefox"
+  mv "$SCRIPT_DIR/build/I2P/config/plugins/plugin" "$SCRIPT_DIR/build/I2P/config/plugins/i2pfirefox"
 fi
 
 for dll in "$I2P_JBIGI/"*windows*.dll; do
@@ -117,7 +124,9 @@ cd "$SCRIPT_DIR"/java
 "$JAVA_HOME"/bin/javac -Xlint:deprecation -d ../build -classpath "$SCRIPT_DIR/build/i2pfirefox.jar:$SCRIPT_DIR/build/jna.jar:$SCRIPT_DIR/build/jna-platform.jar":"$SCRIPT_DIR/build/i2p.jar:$SCRIPT_DIR/build/router.jar:$SCRIPT_DIR/build/routerconsole.jar:$SCRIPT_DIR/build/jbigi.jar" \
   net/i2p/router/CopyConfigDir.java \
   net/i2p/router/WindowsServiceUtil.java \
-  net/i2p/router/WindowsUpdatePostProcessor.java \
+  net/i2p/router/WindowsAppUtil.java \
+  net/i2p/router/I2PAppUtil.java \
+  net/i2p/router/WinUpdatePostProcessor.java \
   net/i2p/router/WinLauncher.java \
   net/i2p/router/WinUpdateProcess.java \
   net/i2p/router/ZipUpdateProcess.java

buildscripts/news.sh

@@ -0,0 +1,65 @@
+#! /usr/bin/env bash
+
+SCRIPT_DIR=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd -P)/..
+cd "$SCRIPT_DIR" || exit 1
+
+. "$SCRIPT_DIR/i2pversion"
+
+if [ -f i2pversion_override ]; then
+    . "$SCRIPT_DIR/i2pversion_override"
+fi
+
+. "$SCRIPT_DIR/config.sh"
+
+if [ -f "$SCRIPT_DIR/config_override.sh" ]; then
+  . "$SCRIPT_DIR/config_override.sh"
+fi
+
+if [ -z "$I2P_NEWSXML" ]; then
+    if [ -d "../i2p.newsxml" ]; then
+        export I2P_NEWSXML="../i2p.newsxml"
+    else 
+        echo "i2p.newsxml is not in the parent directory and I2P_NEWSXML is unset"
+        exit 1
+    fi
+fi
+
+cd "$I2P_NEWSXML" || exit 1 
+export TITLE="Easy-Install for Windows Release $I2P_VERSION"
+echo "$TITLE"
+export AUTHOR=idk
+echo "$AUTHOR"
+export EDITOR=true
+echo "canceled manual editor"
+export I2P_OS=win
+echo "$I2P_OS"
+export I2P_BRANCH=beta
+echo "$I2P_VERSION"
+export SUMMARY_HERE=$(head -n 1 "$SCRIPT_DIR/docs/RELEASE.md" | sed "s|# ||g")
+echo "$SUMMARY_HERE"
+export CONTENT_HERE=$(tail -n +2 "$SCRIPT_DIR/docs/RELEASE.md" | markdown)
+echo "$CONTENT_HERE"
+./create_new_entry.sh
+
+export DATE=$(date +%Y-%m-%d)
+echo "$DATE"
+MAGNET=$(transmission-show -m "$SCRIPT_DIR/i2pwinupdate.su3.torrent" 2>&1 3>&1 | tail -n 1)
+
+TORRENTJSON='['
+TORRENTJSON+='  {'
+TORRENTJSON+="    \"date\": \"$DATE\","
+TORRENTJSON+="    \"version\": \"$I2P_VERSION\","
+TORRENTJSON+="    \"minVersion\": \"1.5.0\","
+TORRENTJSON+="    \"minJavaVersion\": \"1.8\","
+TORRENTJSON+="    \"updates\": {"
+TORRENTJSON+="      \"su3\": {"
+TORRENTJSON+="        \"torrent\": \"$MAGNET\","
+TORRENTJSON+="        \"url\": ["
+TORRENTJSON+="          \"http://ekm3fu6fr5pxudhwjmdiea5dovc3jdi66hjgop4c7z7dfaw7spca.b32.i2p/i2pwinupdate.su3\""
+TORRENTJSON+='        ]'
+TORRENTJSON+='      }'
+TORRENTJSON+='    }'
+TORRENTJSON+='  }'
+TORRENTJSON+=']'
+
+echo "$TORRENTJSON" | jq

buildscripts/release-torrent.sh

@@ -31,14 +31,14 @@ cp -v "I2P-Easy-Install-Bundle-$I2P_VERSION.exe" "I2P-Easy-Install-Bundle-$I2P_V
 java -cp "$I2P_LIBS/*" net.i2p.crypto.SU3File sign -c ROUTER -f EXE I2P-Easy-Install-Bundle-$I2P_VERSION-signed.exe I2P-Easy-Install-Bundle-$I2P_VERSION-signed.su3 "$HOME/.i2p-plugin-keys/news-su3-keystore.ks" $I2P_VERSION $SIGNER
 rm -f i2pwinupdate.su3.torrent
 cp -v I2P-Easy-Install-Bundle-$I2P_VERSION-signed.su3 i2pwinupdate.su3
-mktorrent \
-		--announce=http://tracker2.postman.i2p/announce.php \
-		--announce=http://w7tpbzncbcocrqtwwm3nezhnnsw4ozadvi2hmvzdhrqzfxfum7wa.b32.i2p/a \
-		--announce=http://mb5ir7klpc2tj6ha3xhmrs3mseqvanauciuoiamx2mmzujvg67uq.b32.i2p/a \
-		i2pwinupdate.su3
+
+java -cp "$I2P_LIBS/*" "org.klomp.snark.Storage" -a http://tracker2.postman.i2p/announce.php -a http://w7tpbzncbcocrqtwwm3nezhnnsw4ozadvi2hmvzdhrqzfxfum7wa.b32.i2p/a -a http://mb5ir7klpc2tj6ha3xhmrs3mseqvanauciuoiamx2mmzujvg67uq.b32.i2p/a -c "$SIGNER" -m "Official torrent for Windows Easy-Install version $I2P_VERSION" i2pwinupdate.su3
+echo "~~~~~~~~~~"
+MAGNET=$(transmission-show -m "i2pwinupdate.su3.torrent" 2>&1 3>&1 | tail -n 1)
+echo "$MAGNET"
 ZIPCHECKSUM=$(sha256sum "i2pwinupdate.su3")
 echo github-release upload -R -u "$GITHUB_USERNAME" -r "i2p.firefox" -f "i2pwinupdate.su3" -l "$ZIPCHECKSUM" -t "$I2P_VERSION" -n "i2pwinupdate.su3"
 github-release upload -R -u "$GITHUB_USERNAME" -r "i2p.firefox" -f "i2pwinupdate.su3" -l "$ZIPCHECKSUM" -t "$I2P_VERSION" -n "i2pwinupdate.su3"
 ZIPCHECKSUM=$(sha256sum "i2pwinupdate.su3.torrent")
 echo github-release upload -R -u "$GITHUB_USERNAME" -r "i2p.firefox" -f "i2pwinupdate.su3.torrent" -l "$ZIPCHECKSUM" -t "$I2P_VERSION" -n "i2pwinupdate.su3.torrent"
-github-release upload -R -u "$GITHUB_USERNAME" -r "i2p.firefox" -f "i2pwinupdate.su3.torrent" -l "$ZIPCHECKSUM" -t "$I2P_VERSION" -n "i2pwinupdate.su3.torrent"
+github-release upload -R -u "$GITHUB_USERNAME" -r "i2p.firefox" -f "i2pwinupdate.su3.torrent" -l "$ZIPCHECKSUM" -t "$I2P_VERSION" -n "i2pwinupdate.su3.torrent"

buildscripts/version.sh

@@ -18,9 +18,9 @@ fi
 echo "!define VERSIONMAJOR $VERSIONMAJOR" > "$SCRIPT_DIR"/src/nsis/i2pbrowser-version.nsi
 echo "!define VERSIONMINOR $VERSIONMINOR" >> "$SCRIPT_DIR"/src/nsis/i2pbrowser-version.nsi
 echo "!define VERSIONBUILD $VERSIONBUILD" >> "$SCRIPT_DIR"/src/nsis/i2pbrowser-version.nsi
-echo "!define I2P_VERSION $PROFILE_VERSION" > "$SCRIPT_DIR"/src/nsis/i2pbrowser-jpackage.nsi
+echo "!define I2P_VERSION $I2P_VERSION" > "$SCRIPT_DIR"/src/nsis/i2pbrowser-jpackage.nsi
 
 mkdir -p "$SCRIPT_DIR"/build
-echo "$PROFILE_VERSION" > "$SCRIPT_DIR"/build/version.txt
-echo "$PROFILE_VERSION" > "$SCRIPT_DIR"/build/version.txt
+echo "$I2P_VERSION" > "$SCRIPT_DIR"/build/version.txt
+echo "$I2P_VERSION" > "$SCRIPT_DIR"/build/version.txt
 sed 's|!define VERSION||g' "$SCRIPT_DIR"/src/nsis/i2pbrowser-version.nsi | sed 's| |=|g' > .version

buildscripts/zip.sh

@@ -16,7 +16,8 @@ TORSOCKS=$(which torsocks)
 if [ -f "${TORSOCKS}" ]; then
     . "${TORSOCKS}" on
 fi
-#"$SCRIPT_DIR"/src/win/torbrowser-windows.sh
+which wsl && wsl ../src/win/torbrowser-windows.sh
+which wsl || "$SCRIPT_DIR"/src/win/torbrowser-windows.sh
 version="$(curl -s https://aus1.torproject.org/torbrowser/update_3/release/downloads.json | jq -r ".version")"
 . "${TORSOCKS}" off
 locale="en-US" # mention your locale. default = en-US

docs/RELEASE.md

@@ -0,0 +1,33 @@
+# I2P Easy-Install Bundle for Windows 2.4.9
+
+This is a pre-release of the I2P Easy-Install Bundle for Windows.
+This changes how the I2P bundle and browser profile manager are installed and integrated with the host system.
+The Easy-Install bundle is now a "portable" system that can be moved to different locations within or between Windows file-systems while retaining all built-in functionality.
+A shortcut for starting the I2P router is still provided by the installer for convenience, but the shortcuts for starting the I2P Browser are now integrated with the I2P desktop UI.
+
+The browser profile manager itself has been split away from the monolithic I2P router+Java/jpackage, and moved into an I2P plugin managed by the router.
+While this was done primarily to reduce how complex the existing code was, this also results in behavior which is closer to the main distribution of I2P for Windows and will lead to a more flexible installer, which can bundle additional default plugins and may be suitable for installation as a Windows service.
+I2P Plugins can also be updated independently of the router that hosts them, so it will be possible to update the browser profile manager independently of the router itself.
+It also means that the browser profile manager can be un-installed by uninstalling the plugin, and much more importantly that the browser profile manager is now compatible with all Java I2P distributions.
+
+**Why a dev build 3 weeks before the release?**
+
+By further delineating the components of the bundle, these changes also affected how the release process happens.
+In particular the build process of each component has been encapsulated in a CI description which can be reproduced on a local PC.
+This simplifies and automates the build process by ensuring that up-to-date build tools are installed in a brand-new container for every build.
+In effect this should speed up the release process for I2P Easy-Install for Windows considerably.
+This release is a test-run of the new process, so I can document what is going on.
+It breaks down roughly like this:
+
+ - It takes ~22 minutes to compile all the targets for the `i2p.plugins.firefox` and make the resulting artifacts available. During this process, I must insert 1 HSM and enter 1 password. (This part used to be about 30 steps, now it takes 1)
+ - It takes ~22 minutes to compile all the targets for the `i2p.firefox` project and make the resulting artifacts available. This process produces only unsigned artifacts identified by their hashes, and is non-interactive. (This part used to be around 60 steps the first time, and 40 steps each additional time)
+ - `i2p.firefox` updates are signed in their `.su3` form. The `NSIS`-powered `.exe` installer is the current updater. The next step is to sign *just this installer* and generate a torrent of the result. (This process used to depend on the previous build process and couldn't be done independently. Now it takes about 30 seconds)
+ - Generate and sign a newsfeed to notify the users of an update. This process is the only process that is **slower** when containerized, because there are dozens of feeds to be signed in their respective containers. It takes about an hour.
+
+For you the end user, nothing much should change.
+You'll get your updates a lot faster, and have more options available for testing.
+The same installer is used for the updater, and the process is handled the same way.
+However for developers, testers, and maintainers, this release will result in big changes for the better.
+
+This release still embeds a `2.4.0` Java I2P router. No changes have been made to update the embedded router.
+Network behavior will be unchanged until the official `2.5.0` release.

i2pversion

@@ -2,14 +2,25 @@
 
 JNA_VERSION=5.12.1
 export JNA_VERSION=5.12.1
-I2PFIREFOX_VERSION=1.0.9
-export I2PFIREFOX_VERSION=1.0.9
-# Comment this out to build from an alternate branch or
-# the tip of the master branch.
-VERSIONMAJOR=2
-VERSIONMINOR=4
-VERSIONBUILD=0
+I2PFIREFOX_VERSION=1.4.991
+export I2PFIREFOX_VERSION=1.4.991
+
+export GITHUB_TAG=$(git describe --tags --abbrev=0 | sed 's|i2p||g' | tr -d [a-z-])
+VERSIONMAJOR=$(echo "$GITHUB_TAG" | cut -d . -f 1)
+VERSIONMINOR=$(echo "$GITHUB_TAG" | cut -d . -f 2)
+VERSIONBUILD=$(echo "$GITHUB_TAG" | cut -d . -f 3)
+if [ -z "$VERSIONBUILD" ]; then
+    VERSIONBUILD=2
+fi
+if [ -z "$VERSIONMINOR" ]; then
+    VERSIONMINOR=4
+fi
+if [ -z "$VERSIONMAJOR" ]; then
+    VERSIONMAJOR=0
+fi
 I2P_VERSION="$VERSIONMAJOR.$VERSIONMINOR.$VERSIONBUILD"
 export I2P_VERSION="$VERSIONMAJOR.$VERSIONMINOR.$VERSIONBUILD"
+# Comment this out to build from an alternate branch or
+# the tip of the master branch.
 VERSION=i2p-2.4.0
 export VERSION=i2p-2.4.0

java/net/i2p/router/CopyConfigDir.java

@@ -9,26 +9,14 @@ import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.util.logging.FileHandler;
-import java.util.logging.Logger;
 import java.util.logging.SimpleFormatter;
+import net.i2p.util.Log;
 
-public class CopyConfigDir extends WindowsServiceUtil {
-  final Logger logger = Logger.getLogger("configlog");
+public class CopyConfigDir extends I2PAppUtil {
+  final Log logger;
 
-  public void initLogger() {
-    try {
-      // This block configure the logger with handler and formatter
-      FileHandler fh = new FileHandler(logFile().toString());
-      logger.addHandler(fh);
-      SimpleFormatter formatter = new SimpleFormatter();
-      fh.setFormatter(formatter);
-      // the following statement is used to log any messages
-      logger.info("My first log");
-    } catch (SecurityException e) {
-      e.printStackTrace();
-    } catch (IOException e) {
-      e.printStackTrace();
-    }
+  public CopyConfigDir(RouterContext ctx) {
+    logger = ctx.logManager().getLog(CopyConfigDir.class);
   }
 
   public boolean copyDirectory(String baseDir, String workDir) {
@@ -73,7 +61,7 @@ public class CopyConfigDir extends WindowsServiceUtil {
             try {
               jpackagedConfigsInUse.createNewFile();
             } catch (IOException e) {
-              logger.warning(
+              logger.warn(
                   "Error creating jpackaged file, delete config files manually when uninstalling");
             }
           }
@@ -128,164 +116,19 @@ public class CopyConfigDir extends WindowsServiceUtil {
       out.close();
       return 1;
     } catch (Throwable e) {
-      logger.warning(e.toString());
-      logger.warning("failed to copy " + basePath.getAbsolutePath() + " to " +
-                     workPath.getAbsolutePath());
+      logger.warn(e.toString());
+      logger.warn("failed to copy " + basePath.getAbsolutePath() + " to " +
+                  workPath.getAbsolutePath());
       return 0;
     }
   }
 
-  protected File selectHome() { // throws Exception {
-    String path_override = System.getenv("I2P_CONFIG");
-    if (path_override != null) {
-      File path = new File(path_override);
-      if (path != null && path.exists()) {
-        if (path.isDirectory())
-          return path.getAbsoluteFile();
-        else
-          throw new RuntimeException("I2P_CONFIG is not a directory: " + path);
-      }
-    }
-    File i2p = appImageHome();
-    logger.info("Checking for signs of life in I2P_CONFIG directory: " + i2p);
-    return i2p;
-  }
-
-  protected File selectProgramFile() {
-    String path_override = System.getenv("I2P");
-    if (path_override != null) {
-      File path = new File(path_override);
-      if (path.exists()) {
-        if (path.isDirectory())
-          return path.getAbsoluteFile();
-        else
-          throw new RuntimeException("I2P is not a directory: " + path);
-      }
-    }
-    File i2p = appImageHome();
-    logger.info("Checking for signs of life in I2P directory: " + i2p);
-    return i2p;
-  }
-
-  /**
-   * get the path to the java home, for jpackage this is related to the
-   * executable itself, which is handy to know. It's a directory called runtime,
-   * relative to the root of the app-image on each platform:
-   *
-   * Windows - Root of appimage is 1 directory above directory named runtime
-   *     ./runtime
-   *
-   * Linux - Root of appimage is 2 directories above directory named runtime
-   *     ./lib/runtime
-   *
-   * Mac OSX - Unknown for now
-   *
-   * @return
-   */
-  protected File javaHome() {
-    File jrehome = new File(System.getProperty("java.home"));
-    if (jrehome != null) {
-      if (jrehome.exists()) {
-        return jrehome;
-      }
-    }
-    return null;
-  }
-
-  /**
-   * get the path to the root of the app-image root by getting the path to
-   * java.home and the OS, and traversing up to the app-image root based on that
-   * information.
-   *
-   * @return the app-image root
-   */
-  protected File appImageHome() {
-    File jreHome = javaHome();
-    if (jreHome != null) {
-      switch (osName()) {
-      case "windows":
-        return jreHome.getAbsoluteFile().getParentFile();
-      case "mac":
-      case "linux":
-        return jreHome.getAbsoluteFile().getParentFile().getParentFile();
-      }
-    }
-    return null;
-  }
-
-  /**
-   * get the path to the binary of the app-image root by getting the path to
-   * java.home and the OS, and traversing up to the app-image root based on that
-   * information, then getting the binary path on a per-platform basis. The path
-   * returned will be relative to the root.
-   *
-   * @return the app-image root
-   */
-  protected String appImageExe() {
-    File aih = appImageHome();
-    if (aih != null) {
-      switch (osName()) {
-      case "windows":
-        return "I2P.exe";
-      case "mac":
-      case "linux":
-        return "./bin/I2P";
-      }
-    }
-    return null;
-  }
-
-  /**
-   * get the path to the default config of the app-image by getting the path to
-   * java.home and the OS, and traversing up to the app-image root based on that
-   * information, then appending the config directory to the end onn a
-   * per-platform basis
-   *
-   * @return the app-image root
-   */
-  protected File appImageConfig() {
-    File aih = appImageHome();
-    if (aih == null) {
-      return null;
-    }
-    String osName = osName();
-    switch (osName) {
-    case "windows":
-      File winConfigDir = new File(aih, "config");
-      if (winConfigDir != null) {
-        if (winConfigDir.exists()) {
-          return winConfigDir;
-        }
-      }
-    case "mac":
-    case "linux":
-      File linConfigDir = new File(aih, "lib/config");
-      if (linConfigDir != null) {
-        if (linConfigDir.exists()) {
-          return linConfigDir;
-        }
-      }
-    }
-    return null;
-  }
-
   protected boolean copyConfigDir() {
     File appImageConfigDir = appImageConfig();
     File appImageHomeDir = selectHome();
     return copyConfigDirectory(appImageConfigDir, appImageHomeDir);
   }
 
-  protected String routerConfig() {
-    File appImageHomeDir = selectHome();
-    File routerConf = new File(appImageHomeDir, "router.config");
-    if (routerConf != null) {
-      if (routerConf.exists()) {
-        return routerConf.getAbsolutePath();
-      }
-    }
-    return null;
-  }
-
   /**
    * set up the path to the log file
    *
@@ -299,7 +142,7 @@ public class CopyConfigDir extends WindowsServiceUtil {
    * @return
    */
   protected File logFile(String p) {
-    File log = new File(selectProgramFile(), "logs");
+    File log = new File(selectHome(), "logs");
     if (!log.exists())
       log.mkdirs();
     return new File(log, p);

java/net/i2p/router/I2PAppUtil.java

@@ -0,0 +1,106 @@
+package net.i2p.router;
+
+import java.io.File;
+import java.io.IOException;
+import javax.swing.JOptionPane;
+
+public class I2PAppUtil extends WindowsAppUtil {
+  public String ServiceUpdaterString() {
+    return "http://tc73n4kivdroccekirco7rhgxdg5f3cjvbaapabupeyzrqwv5guq.b32.i2p/news.su3";
+  }
+  public String ServiceBackupUpdaterString() {
+    return "http://dn3tvalnjz432qkqsvpfdqrwpqkw3ye4n4i2uyfr4jexvo3sp5ka.b32.i2p/news.su3";
+  }
+  public String ServiceStaticUpdaterString() {
+    return "http://echelon.i2p/i2p/i2pupdate.sud,http://stats.i2p/i2p/i2pupdate.sud";
+  }
+
+  public String getProgramFilesInstall() {
+    String programFiles = System.getenv("PROGRAMFILES");
+    if (programFiles != null) {
+      File programFilesI2P = new File(programFiles, "i2p/i2p.exe");
+      if (programFilesI2P.exists())
+        return programFilesI2P.getAbsolutePath();
+    }
+    String programFiles86 = System.getenv("PROGRAMFILES86");
+    if (programFiles86 != null) {
+      File programFiles86I2P = new File(programFiles86, "i2p/i2p.exe");
+      if (programFiles86I2P.exists())
+        return programFiles86I2P.getAbsolutePath();
+    }
+    return null;
+  }
+
+  public boolean checkProgramFilesInstall() {
+    String programFiles = System.getenv("PROGRAMFILES");
+    if (programFiles != null) {
+      File programFilesI2P = new File(programFiles, "i2p/i2p.exe");
+      if (programFilesI2P.exists())
+        return true;
+    }
+    String programFiles86 = System.getenv("PROGRAMFILES86");
+    if (programFiles86 != null) {
+      File programFiles86I2P = new File(programFiles86, "i2p/i2p.exe");
+      if (programFiles86I2P.exists())
+        return true;
+    }
+    return false;
+  }
+
+  public boolean promptUserInstallStartIfAvailable() {
+    if (osName() != "windows") {
+      return true;
+    }
+    if (checkProgramFilesInstall()) {
+      int a;
+      String message =
+          "It appears you have an existing, unbundled I2P rotuer installed.\n";
+      message +=
+          "However, it is not running yet. Please start it using the shortcut on the desktop.\n";
+      message +=
+          "If you click \"No\", the Easy-Install router will be launched instead.\n";
+      a = JOptionPane.showConfirmDialog(null, message,
+                                        "I2P Service detected not running",
+                                        JOptionPane.YES_NO_OPTION);
+      if (a == JOptionPane.NO_OPTION) {
+        // Do nothing here, this will continue on to launch a jpackaged router
+        return true;
+      } else {
+        try {
+          String pfi = getProgramFilesInstall();
+          if (pfi != null)
+            Runtime.getRuntime().exec(new String[] {pfi});
+        } catch (IOException e) {
+          return false;
+        }
+        return true;
+      }
+    }
+    return true;
+  }
+
+  /**
+   * get the path to the binary of the app-image root by getting the path to
+   * java.home and the OS, and traversing up to the app-image root based on that
+   * information, then getting the binary path on a per-platform basis. The path
+   * returned will be relative to the root.
+   *
+   * @return the app-image root
+   */
+  protected String appImageExe() {
+    File aih = appImageHome();
+    if (aih != null) {
+      // get the name of the aih directory itself, which will be the default
+      // name of the executable as well
+      String baseName = "I2P";
+      switch (osName()) {
+      case "windows":
+        return baseName + ".exe";
+      case "mac":
+      case "linux":
+        return "./bin/" + baseName;
+      }
+    }
+    return null;
+  }
+}

java/net/i2p/router/WinLauncher.java

@@ -5,18 +5,14 @@ import java.net.InetAddress;
 import java.net.ServerSocket;
 import java.net.Socket;
 import java.util.*;
-import java.util.logging.FileHandler;
-import java.util.logging.Logger;
-import java.util.logging.SimpleFormatter;
 import net.i2p.app.ClientAppManager;
 import net.i2p.crypto.*;
-//import net.i2p.i2pfirefox.*;
 import net.i2p.router.Router;
 import net.i2p.router.RouterLaunch;
 import net.i2p.update.*;
 import net.i2p.update.UpdateManager;
-import net.i2p.update.UpdatePostProcessor;
 import net.i2p.update.UpdateType.*;
+import net.i2p.util.Log;
 
 /**
  * Launches a router from %WORKINGDIR%/I2P using configuration data in
@@ -28,59 +24,14 @@ import net.i2p.update.UpdateType.*;
  * appdata
  * router.pid - the pid of the java process.
  */
-public class WinLauncher extends CopyConfigDir {
-  WindowsUpdatePostProcessor wupp = null;
+public class WinLauncher extends I2PAppUtil {
+  private final CopyConfigDir copyConfigDir;
+  WinUpdatePostProcessor wupp = null;
   private Router i2pRouter;
-
-  public static void main(String[] args) {
-    var launcher = new WinLauncher();
-    launcher.setupLauncher();
-    launcher.initLogger();
-    int proxyTimeoutTime = 200;
-    ArrayList<String> newArgsList = new ArrayList<String>();
-
-    if (args != null) {
-      if (args.length > 0) {
-        for (String arg : args) {
-          if (arg.equals("-private")) {
-            launcher.logger.info(
-                "Private browsing is true, profile will be discarded at end of session.");
-          } else if (arg.equals("-chromium")) {
-            launcher.logger.info("Chromium will be selected before Firefox.");
-          } else if (arg.equals("-usability")) {
-            launcher.logger.info(
-                "Usability mode is true, using alternate extensions loadout.");
-          } else if (arg.equals("-noproxycheck")) {
-            proxyTimeoutTime = 0;
-            launcher.logger.info("Proxy timeout time set to zero");
-          } else {
-            // make an effort to not let people launch into sites if the proxy
-            // isn't quite ready yet, but also disable the proxy timeout if
-            // they're reaching a router console
-            if (arg.startsWith("http://localhost:76")) {
-              newArgsList.add(arg);
-              proxyTimeoutTime = 0;
-            } else if (arg.startsWith("http://127.0.0.1:76")) {
-              newArgsList.add(arg);
-              proxyTimeoutTime = 0;
-            } else if (arg.startsWith("https://localhost:76")) {
-              newArgsList.add(arg);
-              proxyTimeoutTime = 0;
-            } else if (arg.startsWith("https://127.0.0.1:76")) {
-              newArgsList.add(arg);
-              proxyTimeoutTime = 0;
-            } else if (proxyTimeoutTime > 0) {
-              newArgsList.add(arg);
-            } else if (!launcher.isAvailable(4444)) {
-              newArgsList.add(arg);
-            }
-          }
-        }
-      }
-    }
-
-    File programs = launcher.programFile();
-    File home = launcher.homeDir();
+  private final Log logger;
+  public WinLauncher() {
+    File programs = programFile();
+    File home = homeDir();
 
     System.setProperty(
         "i2p.dir.base",
@@ -95,38 +46,42 @@ public class WinLauncher extends CopyConfigDir {
      * to find the JVM and Runtime bundle. This broke Windows 11 installs.
      */
     System.setProperty("user.dir", programs.getAbsolutePath());
+
+    i2pRouter = new Router(routerConfig(), System.getProperties());
+    copyConfigDir = new CopyConfigDir(i2pRouter.getContext());
+    logger = i2pRouter.getContext().logManager().getLog(WinLauncher.class);
+  }
+
+  public static void main(String[] args) {
+    var launcher = new WinLauncher();
+    launcher.setupLauncher();
+    int proxyTimeoutTime = 200;
+
     launcher.logger.info("\t" + System.getProperty("user.dir"));
     launcher.logger.info("\t" + System.getProperty("i2p.dir.base"));
     launcher.logger.info("\t" + System.getProperty("i2p.dir.config"));
     launcher.logger.info("\t" + System.getProperty("router.pid"));
     boolean continuerunning = launcher.promptServiceStartIfAvailable("i2p");
     if (!continuerunning) {
-      launcher.logger.severe(
+      launcher.logger.error(
           "Service startup failure, please start I2P service with services.msc");
       System.exit(2);
     }
     continuerunning = launcher.promptUserInstallStartIfAvailable();
     if (!continuerunning) {
-      launcher.logger.severe("User-install startup required.");
+      launcher.logger.error("User-install startup required.");
       System.exit(2);
     }
 
     // This actually does most of what we use NSIS for if NSIS hasn't
     // already done it, which essentially makes this whole thing portable.
-    if (!launcher.copyConfigDir()) {
-      launcher.logger.severe("Cannot copy the configuration directory");
+    if (!launcher.copyConfigDir.copyConfigDir()) {
+      launcher.logger.error("Cannot copy the configuration directory");
       System.exit(1);
     }
 
-    launcher.i2pRouter =
-        new Router(launcher.routerConfig(), System.getProperties());
     if (!launcher.isInstalled("i2p")) {
-      if (launcher.i2pRouter.saveConfig("routerconsole.browser", null)) {
-        launcher.logger.info("removed routerconsole.browser config");
-      }
-      if (launcher.i2pRouter.saveConfig("routerconsole.browser",
-                                        launcher.appImageExe() +
-                                            " -noproxycheck")) {
+      if (launcher.i2pRouter.saveConfig("routerconsole.browser", "NUL")) {
         launcher.logger.info("updated routerconsole.browser config " +
                              launcher.appImageExe());
       }
@@ -138,8 +93,6 @@ public class WinLauncher extends CopyConfigDir {
     registrationThread.setDaemon(true);
     registrationThread.start();
 
-    launcher.setNotStarting();
-
     launcher.i2pRouter.runRouter();
   }
 
@@ -151,11 +104,11 @@ public class WinLauncher extends CopyConfigDir {
   }
 
   private File programFile() {
-    File programs = selectProgramFile();
+    File programs = selectHome();
     if (!programs.exists())
       programs.mkdirs();
     else if (!programs.isDirectory()) {
-      logger.warning(
+      logger.warn(
           programs +
           " exists but is not a directory. Please get it out of the way");
       System.exit(1);
@@ -168,7 +121,7 @@ public class WinLauncher extends CopyConfigDir {
     if (!home.exists())
       home.mkdirs();
     else if (!home.isDirectory()) {
-      logger.warning(
+      logger.warn(
           home +
           " exists but is not a directory. Please get it out of the way");
       System.exit(1);
@@ -188,93 +141,6 @@ public class WinLauncher extends CopyConfigDir {
     return portFree;
   }
 
-  private boolean i2pIsRunningCheck() {
-    // check if there's something listening on port 7657(Router Console)
-    if (!isAvailable(7657))
-      return true;
-    // check if there's something listening on port 7654(I2CP)
-    if (!isAvailable(7654))
-      return true;
-    if (checkPing())
-      return true;
-    return false;
-  }
-
-  private void setNotStarting() {
-    logger.info("removing startup file, the application has started");
-    File home = selectHome();
-    File starting = new File(home, "starting");
-    if (starting.exists()) {
-      starting.delete();
-    }
-  }
-
-  private void setStarting() {
-    logger.info("creating startup file, router is starting up");
-    File home = selectHome();
-    File starting = new File(home, "starting");
-    if (!starting.exists()) {
-      try {
-        starting.createNewFile();
-      } catch (IOException e) {
-        logger.info(e.toString());
-      }
-    }
-    Runtime.getRuntime().addShutdownHook(new Thread() {
-      @Override
-      public void run() {
-        setNotStarting();
-      }
-    });
-  }
-
-  private boolean checkStarting() {
-    logger.info("checking startup file");
-    File home = selectHome();
-    File starting = new File(home, "starting");
-    if (starting.exists()) {
-      logger.info("startup file exists, I2P is already starting up");
-      return true;
-    }
-    logger.info("startup file does not exist but we're running now");
-    setStarting();
-    return false;
-  }
-
-  // check for the existence of router.ping file, if it's less then 2
-  // minutes old, exit
-  private boolean checkPing() {
-    File home = selectHome();
-    File ping = new File(home, "router.ping");
-    if (ping.exists()) {
-      long diff = System.currentTimeMillis() - ping.lastModified();
-      if (diff > 60 * 1000) {
-        logger.info(
-            "router.ping exists and is more than 1 minute old, I2P does not appear to be running.");
-        logger.info("If I2P is running, report this as a bug.");
-        return false;
-      } else {
-        return true;
-      }
-    }
-    return false;
-  }
-
-  private boolean i2pIsRunning() {
-    if (checkStarting())
-      return true;
-    if (checkPing())
-      return true;
-    if (i2pIsRunningCheck())
-      return true;
-    for (int i = 0; i < 10; i++) {
-      if (i2pIsRunningCheck())
-        return true;
-      sleep(1000);
-    }
-    return false;
-  }
-
   private final Runnable REGISTER_UPP = () -> {
     RouterContext ctx;
     while ((ctx = i2pRouter.getContext()) == null) {
@@ -290,7 +156,7 @@ public class WinLauncher extends CopyConfigDir {
            null) {
       sleep(1000);
     }
-    WindowsUpdatePostProcessor wupp = new WindowsUpdatePostProcessor(ctx);
+    WinUpdatePostProcessor wupp = new WinUpdatePostProcessor(ctx);
     um.register(wupp, UpdateType.ROUTER_SIGNED_SU3, SU3File.TYPE_EXE);
     um.register(wupp, UpdateType.ROUTER_DEV_SU3, SU3File.TYPE_EXE);
   };

java/net/i2p/router/WinUpdatePostProcessor.java

@@ -16,7 +16,7 @@ import net.i2p.update.UpdateType;
 import net.i2p.util.Log;
 import net.i2p.util.SystemVersion;
 
-public class WindowsUpdatePostProcessor implements UpdatePostProcessor {
+public class WinUpdatePostProcessor implements UpdatePostProcessor {
   private final Log _log;
   private final RouterContext ctx;
   private final AtomicBoolean hook = new AtomicBoolean();
@@ -26,9 +26,9 @@ public class WindowsUpdatePostProcessor implements UpdatePostProcessor {
 
   private volatile File positionedFile = null;
 
-  WindowsUpdatePostProcessor(RouterContext ctx) {
+  WinUpdatePostProcessor(RouterContext ctx) {
     this.ctx = ctx;
-    this._log = ctx.logManager().getLog(WindowsUpdatePostProcessor.class);
+    this._log = ctx.logManager().getLog(WinUpdatePostProcessor.class);
   }
 
   public String getVersion() { return version; }

java/net/i2p/router/WindowsAppUtil.java

@@ -0,0 +1,143 @@
+package net.i2p.router;
+
+import java.io.File;
+import net.i2p.util.Log;
+
+public class WindowsAppUtil extends WindowsServiceUtil {
+  private File checkPathEnvironmentVariable(String name) {
+    String path_override = System.getenv(name);
+    if (path_override != null) {
+      File path = new File(path_override);
+      if (path != null && path.exists()) {
+        if (path.isDirectory())
+          return path.getAbsoluteFile();
+        else
+          throw new RuntimeException(name + " is not a directory: " + path);
+      }
+    }
+    return null;
+  }
+
+  protected File selectHome() { // throws Exception {
+    File i2p = checkPathEnvironmentVariable("JPACKAGE_HOME");
+    if (i2p == null)
+      i2p = appImageHome();
+    return i2p;
+  }
+
+  /**
+   * get the path to the java home, for jpackage this is related to the
+   * executable itself, which is handy to know. It's a directory called runtime,
+   * relative to the root of the app-image on each platform:
+   *
+   * Windows - Root of appimage is 1 directory above directory named runtime
+   *     ./runtime
+   *
+   * Linux - Root of appimage is 2 directories above directory named runtime
+   *     ./lib/runtime
+   *
+   * Mac OSX - Unknown for now
+   *
+   * @return
+   */
+  protected File javaHome() {
+    File jrehome = new File(System.getProperty("java.home"));
+    if (jrehome != null) {
+      if (jrehome.exists()) {
+        return jrehome;
+      }
+    }
+    return null;
+  }
+
+  /**
+   * get the path to the root of the app-image root by getting the path to
+   * java.home and the OS, and traversing up to the app-image root based on that
+   * information.
+   *
+   * @return the app-image root
+   */
+  protected File appImageHome() {
+    File jreHome = javaHome();
+    if (jreHome != null) {
+      switch (osName()) {
+      case "windows":
+        return jreHome.getAbsoluteFile().getParentFile();
+      case "mac":
+      case "linux":
+        return jreHome.getAbsoluteFile().getParentFile().getParentFile();
+      }
+    }
+    return null;
+  }
+
+  /**
+   * get the path to the binary of the app-image root by getting the path to
+   * java.home and the OS, and traversing up to the app-image root based on that
+   * information, then getting the binary path on a per-platform basis. The path
+   * returned will be relative to the root.
+   *
+   * @return the app-image root
+   */
+  protected String appImageExe() {
+    File aih = appImageHome();
+    if (aih != null) {
+      // get the name of the aih directory itself, which will be the default
+      // name of the executable as well
+      String baseName = aih.getName();
+      switch (osName()) {
+      case "windows":
+        return baseName + ".exe";
+      case "mac":
+      case "linux":
+        return "./bin/" + baseName;
+      }
+    }
+    return null;
+  }
+
+  /**
+   * get the path to the default config of the app-image by getting the path to
+   * java.home and the OS, and traversing up to the app-image root based on that
+   * information, then appending the config directory to the end onn a
+   * per-platform basis
+   *
+   * @return the app-image root
+   */
+  protected File appImageConfig() {
+    File aih = appImageHome();
+    if (aih == null) {
+      return null;
+    }
+    String osName = osName();
+    switch (osName) {
+    case "windows":
+      File winConfigDir = new File(aih, "config");
+      if (winConfigDir != null) {
+        if (winConfigDir.exists()) {
+          return winConfigDir;
+        }
+      }
+    case "mac":
+    case "linux":
+      File linConfigDir = new File(aih, "lib/config");
+      if (linConfigDir != null) {
+        if (linConfigDir.exists()) {
+          return linConfigDir;
+        }
+      }
+    }
+    return null;
+  }
+
+  protected String routerConfig() {
+    File appImageHomeDir = selectHome();
+    File routerConf = new File(appImageHomeDir, "router.config");
+    if (routerConf != null) {
+      if (routerConf.exists()) {
+        return routerConf.getAbsolutePath();
+      }
+    }
+    return null;
+  }
+}

java/net/i2p/router/WindowsServiceUtil.java

@@ -145,87 +145,13 @@ public class WindowsServiceUtil {
             return false;
           }
         }
-        return isStart("i2p");
+        return isStart(serviceName);
       }
       return true;
     }
     return true;
   }
 
-  public String ServiceUpdaterString() {
-    return "http://tc73n4kivdroccekirco7rhgxdg5f3cjvbaapabupeyzrqwv5guq.b32.i2p/news.su3";
-  }
-  public String ServiceBackupUpdaterString() {
-    return "http://dn3tvalnjz432qkqsvpfdqrwpqkw3ye4n4i2uyfr4jexvo3sp5ka.b32.i2p/news.su3";
-  }
-  public String ServiceStaticUpdaterString() {
-    return "http://echelon.i2p/i2p/i2pupdate.sud,http://stats.i2p/i2p/i2pupdate.sud";
-  }
-
-  public String getProgramFilesInstall() {
-    String programFiles = System.getenv("PROGRAMFILES");
-    if (programFiles != null) {
-      File programFilesI2P = new File(programFiles, "i2p/i2p.exe");
-      if (programFilesI2P.exists())
-        return programFilesI2P.getAbsolutePath();
-    }
-    String programFiles86 = System.getenv("PROGRAMFILES86");
-    if (programFiles86 != null) {
-      File programFiles86I2P = new File(programFiles86, "i2p/i2p.exe");
-      if (programFiles86I2P.exists())
-        return programFiles86I2P.getAbsolutePath();
-    }
-    return null;
-  }
-
-  public boolean checkProgramFilesInstall() {
-    String programFiles = System.getenv("PROGRAMFILES");
-    if (programFiles != null) {
-      File programFilesI2P = new File(programFiles, "i2p/i2p.exe");
-      if (programFilesI2P.exists())
-        return true;
-    }
-    String programFiles86 = System.getenv("PROGRAMFILES86");
-    if (programFiles86 != null) {
-      File programFiles86I2P = new File(programFiles86, "i2p/i2p.exe");
-      if (programFiles86I2P.exists())
-        return true;
-    }
-    return false;
-  }
-
-  public boolean promptUserInstallStartIfAvailable() {
-    if (osName() != "windows") {
-      return true;
-    }
-    if (checkProgramFilesInstall()) {
-      int a;
-      String message =
-          "It appears you have an existing, unbundled I2P rotuer installed.\n";
-      message +=
-          "However, it is not running yet. Please start it using the shortcut on the desktop.\n";
-      message +=
-          "If you click \"No\", the Easy-Install router will be launched instead.\n";
-      a = JOptionPane.showConfirmDialog(null, message,
-                                        "I2P Service detected not running",
-                                        JOptionPane.YES_NO_OPTION);
-      if (a == JOptionPane.NO_OPTION) {
-        // Do nothing here, this will continue on to launch a jpackaged router
-        return true;
-      } else {
-        try {
-          String pfi = getProgramFilesInstall();
-          if (pfi != null)
-            Runtime.getRuntime().exec(new String[] {pfi});
-        } catch (IOException e) {
-          return false;
-        }
-        return true;
-      }
-    }
-    return true;
-  }
-
   public String getServiceState(String serviceName) {
     String stateString = "uninstalled";
     int state = getServiceStateInt(serviceName);

src/nsis/i2pbrowser-installer.nsi

@@ -181,11 +181,13 @@ Function installerFunction
 
     SetOutPath "$INSTDIR"
     createDirectory "$SMPROGRAMS\${APPNAME}"
+    
     CreateShortCut "$SMPROGRAMS\${APPNAME}\Browse I2P.lnk" "$INSTDIR\I2P.exe" "" "$INSTDIR\ui2pbrowser_icon.ico"
-    CreateShortCut "$SMPROGRAMS\${APPNAME}\Browse I2P - Temporary Identity.lnk" "$INSTDIR\I2P.exe -private" "" "$INSTDIR\ui2pbrowser_icon.ico"
+    Delete "$SMPROGRAMS\${APPNAME}\Browse I2P - Temporary Identity.lnk"
 
     CreateShortCut "$DESKTOP\Browse I2P.lnk" "$INSTDIR\I2P.exe" "" "$INSTDIR\ui2pbrowser_icon.ico"
-    CreateShortCut "$DESKTOP\Browse I2P - Temporary Identity.lnk" "$INSTDIR\I2P.exe -private" "" "$INSTDIR\ui2pbrowser_icon.ico"
+    Delete "$DESKTOP\Browse I2P - Temporary Identity.lnk"
+
     CreateShortCut "$SMPROGRAMS\${APPNAME}\Uninstall I2P Easy-Install Bundle.lnk" "$INSTDIR\uninstall-i2pbrowser.exe" "" "$INSTDIR\ui2pbrowser_icon.ico"
     SetOutPath "$INSTDIR"
 

src/win/torbrowser-windows.sh

@@ -18,21 +18,11 @@ if [ ! -f ./tor.keyring ]; then
 fi
 
 if [ ! -f "tor-browser-linux64-${version}_${locale}.exe" ]; then
-    wget -cv "https://www.torproject.org/dist/torbrowser/${version}/torbrowser-install-win64-${version}_${locale}.exe" 
-    wget -cv "https://www.torproject.org/dist/torbrowser/${version}/torbrowser-install-win64-${version}_${locale}.exe.asc"
+    wget -cv "https://dist.torproject.org/torbrowser/${version}/tor-browser-windows-x86_64-portable-${version}.exe"
+    wget -cv "https://dist.torproject.org/torbrowser/${version}/tor-browser-windows-x86_64-portable-${version}.exe.asc"
 fi
 
-gpgv --keyring ./tor.keyring "torbrowser-install-win64-${version}_${locale}.exe.asc" "torbrowser-install-win64-${version}_${locale}.exe"
+gpgv --keyring ./tor.keyring "tor-browser-windows-x86_64-portable-${version}.exe.asc" "tor-browser-windows-x86_64-portable-${version}.exe"
 
-#tar xvJf "torbrowser-install-win64-${version}_${locale}.exe"
-#for n in `seq 1 2000`; do echo $n; dd ibs=256 if="torbrowser-install-win64-${version}_${locale}.exe" count=2 skip=$n | file - ; done 2>/dev/null |less
-#zip -FF "torbrowser-install-win64-${version}_${locale}.exe" --out extracted.zip
-WINE=$(which wine)
-if [ -z "$WINE" ]; then
-    "./torbrowser-install-win64-${version}_${locale}.exe" /S #/D .
-    cp -vr "$HOME/Desktop/Tor Browser/" "Tor Browser"
-else
-    export WINEPREFIX=$(pwd)/../tmp
-    $WINE "torbrowser-install-win64-${version}_${locale}.exe" /S #/D .
-    cp -vr "$WINEPREFIX/drive_c/users/idk/Desktop/Tor Browser/" "Tor Browser"
-fi
+7z x "tor-browser-windows-x86_64-portable-${version}.exe" -o"Tor Browser"
+#7z --help